Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22590 )
Change subject: IMPALA-12931: (Addendum) Slow test_no_hms_event_incremental_refresh ...................................................................... Patch Set 3: (2 comments) Thank you for the review! http://gerrit.cloudera.org:8080/#/c/22590/3/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/22590/3/tests/custom_cluster/test_events_custom_configs.py@55 PS3, Line 55: def wait_statestore_heartbeat(num_heartbeat=1): > Nit: would be good to combine this code and the changes from https://gerrit Ack. Will do it in separate patch. http://gerrit.cloudera.org:8080/#/c/22590/3/tests/custom_cluster/test_events_custom_configs.py@1286 PS3, Line 1286: "ACID table is not updated. Create statement: {}").format(create_stmt) > Nit: the query id can be very helpful as well as it enables quickly searchi Query ID and all other SQL will still show up in jenkins. This just to help next triager to see immediately if the partitioned or the non-partitioned case was failed. -- To view, visit http://gerrit.cloudera.org:8080/22590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0 Gerrit-Change-Number: 22590 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 06 Mar 2025 18:14:36 +0000 Gerrit-HasComments: Yes
