Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/22353 )
Change subject: IMPALA-13586: Initial support for Iceberg REST Catalogs ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/22353/2/be/src/service/frontend.h File be/src/service/frontend.h: http://gerrit.cloudera.org:8080/#/c/22353/2/be/src/service/frontend.h@93 PS2, Line 93: TGetCatalogInfoResult* Pass by reference http://gerrit.cloudera.org:8080/#/c/22353/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/22353/2/be/src/service/frontend.cc@261 PS2, Line 261: TGetCatalogInfoResult* Pass by reference http://gerrit.cloudera.org:8080/#/c/22353/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/22353/2/be/src/service/impala-server.cc@3136 PS2, Line 3136: return Status("Workload management needs CatalogD to be deployed."); Add a TODO and JIRA# to support workload management. http://gerrit.cloudera.org:8080/#/c/22353/2/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergRESTCatalog.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergRESTCatalog.java: http://gerrit.cloudera.org:8080/#/c/22353/2/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergRESTCatalog.java@54 PS2, Line 54: public static IcebergRESTCatalog getInstance(TBackendGflags flags) { Does this need to be synchronized? -- To view, visit http://gerrit.cloudera.org:8080/22353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1722b898b568d2f5689002f2b9bef59320cb088c Gerrit-Change-Number: 22353 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Mar 2025 17:16:33 +0000 Gerrit-HasComments: Yes
