Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22306 )
Change subject: IMPALA-13653: Create hooks for Calcite planner in Frontend ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/22306/11/fe/src/main/java/org/apache/impala/service/CompilerFactory.java File fe/src/main/java/org/apache/impala/service/CompilerFactory.java: http://gerrit.cloudera.org:8080/#/c/22306/11/fe/src/main/java/org/apache/impala/service/CompilerFactory.java@54 PS11, Line 54: /** : * Return a fallback compiler factory given a planner context allowing the : * implementation to choose if it should fallback based on a query option or : * the type of exception thrown by the failed compiler factory. : */ : public CompilerFactory getFallbackFactory(TQueryOptions options, Exception e); > I would prefer to keep fallback external to the compiler. I don't think the Down the road, I was thinking that eventually we are going to treat Calcite as the default compiler and the Impala planner as the legacy. In addition to this, we might have various options doing different types of fallback. Heck, it might even return a different version of the Calcite factory. Given that each compiler is going to do its own thing and have various options, I thought it would be nice to let the compiler return the fallback factory. If you want me to keep things simple for now, I guess I'm ok with it. Not gonna fight hard on this one, but hardcoding the legacy factory as the fallback is gonna change in the future. -- To view, visit http://gerrit.cloudera.org:8080/22306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I978aa48b160984ee5d36244cd915940f838d141d Gerrit-Change-Number: 22306 Gerrit-PatchSet: 11 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Mar 2025 04:57:41 +0000 Gerrit-HasComments: Yes
