Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22339 )
Change subject: IMPALA-13609: Store Iceberg snapshot id for COMPUTE STATS ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/22339/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22339/3//COMMIT_MSG@41 PS3, Line 41: : Note that this change does not yet modify how Impala ch > Of course the transposing step can be omitted, and we can create the ranges I implemented ranges and removed the limit on the number of columns. Still, in the worst case, we may have lots of columns with stats belonging to different snapshots. http://gerrit.cloudera.org:8080/#/c/22339/5/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/22339/5/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@817 PS5, Line 817: } > I think here currentSnapshotId can be newer than the one actually being use Do you mean the same problem that is described in the commit message, i.e. during the time from the actual stats calculation until this point, there can be a new snapshot? I think you're right, I'll try to come up with a solution. -- To view, visit http://gerrit.cloudera.org:8080/22339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9998b84c4fd20d1cf5e97a34f3553832ec70ae7 Gerrit-Change-Number: 22339 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 03 Mar 2025 16:00:05 +0000 Gerrit-HasComments: Yes
