Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22531 )
Change subject: IMPALA-13785: Deflake test_catalog_tables_stats in exhaustive build ...................................................................... IMPALA-13785: Deflake test_catalog_tables_stats in exhaustive build IMPALA-13737 changed how we load file metadata for Iceberg tables, as we don't rely on the underlying HdfsTable anymore. As a result, metrics were not correctly updated. This patch adds code to update metrics correctly. Testing: * executed the tests in the title in exhaustive mode * added Iceberg-specific tests to test_web_pages Change-Id: I686e0e32b36ace4c5a8c9eeb715148c98521252a Reviewed-on: http://gerrit.cloudera.org:8080/22531 Reviewed-by: Quanlong Huang <[email protected]> Reviewed-by: Noemi Pap-Takacs <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Riza Suminto <[email protected]> --- M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java M fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java M tests/webserver/test_web_pages.py 7 files changed, 127 insertions(+), 70 deletions(-) Approvals: Quanlong Huang: Looks good to me, but someone else must approve Noemi Pap-Takacs: Looks good to me, but someone else must approve Impala Public Jenkins: Verified Riza Suminto: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I686e0e32b36ace4c5a8c9eeb715148c98521252a Gerrit-Change-Number: 22531 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
