Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22549 )
Change subject: IMPALA-13798: Clear of host-level remote scratch dir on shutdown ...................................................................... Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-13798: Clear of host-level remote scratch dir on shutdown Maybe: "Cleanup host-level remote scratch dir on shutdown" http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@9 PS2, Line 9: cleanup cleanup of http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@14 PS2, Line 14: removed removes or adds support for removing http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@14 PS2, Line 14: this this behavior http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@14 PS2, Line 14: permanently or hostname changes. http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@20 PS2, Line 20: remote_scratch_cleanup_on_startstop nit: remote_scratch_cleanup_on_start_stop http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@21 PS2, Line 21: to remove "to" http://gerrit.cloudera.org:8080/#/c/22549/2//COMMIT_MSG@21 PS2, Line 21: as well either remove "also" or "as well" from this sentence. http://gerrit.cloudera.org:8080/#/c/22549/2/be/src/runtime/tmp-file-mgr.h File be/src/runtime/tmp-file-mgr.h: http://gerrit.cloudera.org:8080/#/c/22549/2/be/src/runtime/tmp-file-mgr.h@209 PS2, Line 209: void ClearForShutdown(); Maybe CleanupAtShutdown() is more clear? -- To view, visit http://gerrit.cloudera.org:8080/22549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f446894afdf975630aef80a9d964a9a78d3b46 Gerrit-Change-Number: 22549 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2025 00:32:31 +0000 Gerrit-HasComments: Yes
