Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22553 )
Change subject: IMPALA-13803: Fix hiveserver2_protocol_version Values in Workload Management ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22553/2/be/src/service/query-state-record.h File be/src/service/query-state-record.h: http://gerrit.cloudera.org:8080/#/c/22553/2/be/src/service/query-state-record.h@360 PS2, Line 360: std::string hiveserver2_protocol_version_formatted() const; > Please say in the comment that this is protocol version of Impala client. Updated comment to clarify. I would prefer to skip testing of different HS2 versions simply because it will require adding a very different kind of test that subclasses HS2TestSuite. Additionally, such tests are essentially asserting the query profile has the correct value for the "HiveServer2 Protocol Version" portion (which is not really the purpose of the impala_query_live.py/impala_query_log.py custom cluster tests). -- To view, visit http://gerrit.cloudera.org:8080/22553 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd8121d4fbf7abe12d313f3314377db6f1ec017a Gerrit-Change-Number: 22553 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2025 23:55:49 +0000 Gerrit-HasComments: Yes
