Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22425 )
Change subject: IMPALA-12959: Calcite planner: Implement count star optimization... ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/22425/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22425/6//COMMIT_MSG@7 PS6, Line 7: IMPALA-12959: Calcite planner: Implement count star optimzation... > typo: optimization Wow, a misspelling in the header. Slightly embarrassing, lol http://gerrit.cloudera.org:8080/#/c/22425/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/22425/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@a1983 PS6, Line 1983: > Why is this different? Good question, and I didn't really have a place for a comment for this. The Calcite planner doesn't use any substitution maps. I was trying to decide whether it was worth it to keep the precondition in for the non Calcite case? Would be a little awkward though, so I decided against. I can be persuaded to have my mind changed, but I'm not sure exactly how to do it. http://gerrit.cloudera.org:8080/#/c/22425/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java: http://gerrit.cloudera.org:8080/#/c/22425/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@180 PS6, Line 180: * produce the SlotDescriptor objects needed for the query.o > typo: extra "o" at the end Done http://gerrit.cloudera.org:8080/#/c/22425/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@182 PS6, Line 182: * XXX: Reviewer note: This code was moved from CalciteTable, so it's not new > Ack. Gonna leave this note in until I get another reviewer http://gerrit.cloudera.org:8080/#/c/22425/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeWithExprs.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeWithExprs.java: http://gerrit.cloudera.org:8080/#/c/22425/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeWithExprs.java@48 PS6, Line 48: this.planNode_ = planNode; > nit: this could also call NodeWithExprs Done -- To view, visit http://gerrit.cloudera.org:8080/22425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I975beefedd2cceb34dad0f93343a46d1b7094c13 Gerrit-Change-Number: 22425 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2025 23:30:24 +0000 Gerrit-HasComments: Yes
