Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/22411 )
Change subject: IMPALA-13716: Calcite Planner: TupleIsNullPredicate fix for analytic functions ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/22411/8/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/22411/8/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@154 PS8, Line 154: tupleIsNullPreds = emptyPreds; > It would have to be in the firstSortGroup, not the last. The tupleIsNullPr >> firstSortGroup ? tupleIsNullPreds : emptyPreds This is a lot better because we should not modify an input variable to this method. Sorry I didn't catch this sooner. If you can make this change, it is good to go from my side. -- To view, visit http://gerrit.cloudera.org:8080/22411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaec363c2fa93a1e21bf74a40e5399e21ddd9bd60 Gerrit-Change-Number: 22411 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2025 19:53:12 +0000 Gerrit-HasComments: Yes
