Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20169 )
Change subject: IMPALA-11980 (part 1): Put all thrift-generated python code into the impala_thrift_gen package ...................................................................... Patch Set 10: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/20169/10/tests/util/get_parquet_metadata.py File tests/util/get_parquet_metadata.py: http://gerrit.cloudera.org:8080/#/c/20169/10/tests/util/get_parquet_metadata.py@27 PS10, Line 27: from impala_thrift_gen.parquet.ttypes import (ColumnIndex, FileMetaData, OffsetIndex, flake8: F401 'impala_thrift_gen.parquet.ttypes.ColumnIndex' imported but unused http://gerrit.cloudera.org:8080/#/c/20169/10/tests/util/get_parquet_metadata.py@27 PS10, Line 27: from impala_thrift_gen.parquet.ttypes import (ColumnIndex, FileMetaData, OffsetIndex, flake8: F401 'impala_thrift_gen.parquet.ttypes.OffsetIndex' imported but unused http://gerrit.cloudera.org:8080/#/c/20169/10/tests/util/get_parquet_metadata.py@27 PS10, Line 27: from impala_thrift_gen.parquet.ttypes import (ColumnIndex, FileMetaData, OffsetIndex, flake8: F401 'impala_thrift_gen.parquet.ttypes.PageHeader' imported but unused -- To view, visit http://gerrit.cloudera.org:8080/20169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2927f22c7257aa38a78084efe5bd76d566493c0 Gerrit-Change-Number: 20169 Gerrit-PatchSet: 10 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Feb 2025 18:06:56 +0000 Gerrit-HasComments: Yes
