Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22532 )
Change subject: IMPALA-13781: Fix "Median Diff %" for report_benchmark_results.py ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22532/2/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: http://gerrit.cloudera.org:8080/#/c/22532/2/tests/benchmark/report_benchmark_results.py@349 PS2, Line 349: results, ref_results nit: Renaming to current_impala_result vs ref_impala_result will help avoid another confusion in the future. This also align with naming in other function: def build_summary_header(current_impala_version, ref_impala_version): -- To view, visit http://gerrit.cloudera.org:8080/22532 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f9da14bc7d5b6ef6a795b9024760f8cae77d72f Gerrit-Change-Number: 22532 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 24 Feb 2025 18:53:30 +0000 Gerrit-HasComments: Yes
