Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22459 )
Change subject: IMPALA-13611: Add interop tests for Iceberg tables ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22459/1/tests/stress/test_update_stress.py File tests/stress/test_update_stress.py: http://gerrit.cloudera.org:8080/#/c/22459/1/tests/stress/test_update_stress.py@215 PS1, Line 215: """Writes ascending numbers up to 'num_inserts' into column 'i'. To column 'wid' it This comment doesn't seem to be for this function. Neither 'num_inserts' nor 'wid' exist. http://gerrit.cloudera.org:8080/#/c/22459/1/tests/stress/test_update_stress.py@358 PS1, Line 358: def test_iceberg_impala_deletes_and_hive_updates(self, unique_database): Couldn't the implementations of these two functions be merged, with the deleter, updater and checker passed in as paremeters? http://gerrit.cloudera.org:8080/#/c/22459/1/tests/stress/test_update_stress.py@409 PS1, Line 409: self.client.execute("refresh %s" % tbl_name) Is it intentional that test_iceberg_impala_deletes_and_hive_updates doesn't call REFRESH? -- To view, visit http://gerrit.cloudera.org:8080/22459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2ee6d3354c3b11264c5e3ded9826831e3962a98 Gerrit-Change-Number: 22459 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 24 Feb 2025 15:27:24 +0000 Gerrit-HasComments: Yes
