Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22411 )
Change subject: IMPALA-13716: Calcite Planner: TupleIsNullPredicate fix for analytic functions ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/22411/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22411/6//COMMIT_MSG@16 PS6, Line 16: select avg(af1), sum(af3), count(a) > Sorry if my previous comment gave the impression of needing the full query Heh, yeah, it was simplest just to grab the known query failure. I didn't want to spend too much time on finding the query. I simplified it a little, but when I made it too simple, the query would work. I hope the current query is ok, otherwise I can spend a little longer, but I don't really want to spend too much more time on this, since the new query will reproduce the error and this code fixes the query anyway. http://gerrit.cloudera.org:8080/#/c/22411/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java: http://gerrit.cloudera.org:8080/#/c/22411/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@150 PS6, Line 150: .filter(e -> e != null).collect(Collectors.toList()); > nit: pls remove the trailing ws Done -- To view, visit http://gerrit.cloudera.org:8080/22411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaec363c2fa93a1e21bf74a40e5399e21ddd9bd60 Gerrit-Change-Number: 22411 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 24 Feb 2025 03:22:58 +0000 Gerrit-HasComments: Yes
