Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22511 )
Change subject: IMPALA-13772: Fix Workload Management DMLs Timeouts ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/22511/6/be/src/service/workload-management-worker.cc File be/src/service/workload-management-worker.cc: http://gerrit.cloudera.org:8080/#/c/22511/6/be/src/service/workload-management-worker.cc@678 PS6, Line 678: if (!FLAGS_debug_actions.empty()) { : insert_query_opts[TImpalaQueryOptions::DEBUG_ACTION] = FLAGS_debug_actions; : } > nit: Unrelated, but this makes me ask, should WM code follow --default_quer Good quesiton. The --default_query_options do get added to the workload management insert DML. I'm not sure where it happens, but they are added. I investigated adding a separate flag for workload management insert DML query options but it proved to be quite a bit more difficult than I hoped, and I did not want to touch such a central piece of code. -- To view, visit http://gerrit.cloudera.org:8080/22511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cc7fbce40eadfb253d8cff5cbb83e2ad63a979f Gerrit-Change-Number: 22511 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 21 Feb 2025 18:51:39 +0000 Gerrit-HasComments: Yes
