Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22411 )
Change subject: IMPALA-13716: Calcite Planner: TupleIsNullPredicate fix for analytic functions ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/22411/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22411/4//COMMIT_MSG@13 PS4, Line 13: > Can you add in the commit message an example query which is benefited by th Done http://gerrit.cloudera.org:8080/#/c/22411/4/fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java File fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java: http://gerrit.cloudera.org:8080/#/c/22411/4/fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java@216 PS4, Line 216: /** > nit: this is a public method, so would be good to add a short comment. Wha Done http://gerrit.cloudera.org:8080/#/c/22411/4/fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java@222 PS4, Line 222: List<Expr> exprs, List<TupleId> tids) { > Why would expr be null here ? I would think exprs list is only non-null va I'm not sure? I'm gonna remove this and re-test. If everything works fine, I'll leave it as/is. If something is broken, I'll put in a proper comment. http://gerrit.cloudera.org:8080/#/c/22411/4/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/22411/4/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@105 PS4, Line 105: public PlanNode createSingleNodePlan(PlanNode root, > nit: update the javadoc above with a short description of this new paramete Done http://gerrit.cloudera.org:8080/#/c/22411/4/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/22411/4/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@2364 PS4, Line 2364: getTupleIsNullPreds(Plan > Not sure why this says 'Input' in the name. This method is only looking at Yeah, I misnamed this. in AnalyticPlanner, it is referred to as "input", but it is really looking off of "root". But I did run this through at least once and it worked fine. -- To view, visit http://gerrit.cloudera.org:8080/22411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaec363c2fa93a1e21bf74a40e5399e21ddd9bd60 Gerrit-Change-Number: 22411 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2025 19:11:24 +0000 Gerrit-HasComments: Yes
