Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20131 )
Change subject: IMPALA-12152: Add query options to wait for HMS events sync up ...................................................................... Patch Set 37: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/20131/37/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/20131/37/common/thrift/CatalogService.thrift@788 PS37, Line 788: // Set to true for SHOW TABLES/VIEWS statesments. typo: statements http://gerrit.cloudera.org:8080/#/c/20131/37/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/20131/37/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4200 PS37, Line 4200: @Nullable Table tbl, String dbName, String tblName, boolean wantMinimalResponse) { nit: This method seems like it should be two methods, either taking tbl or dbName/tblName. I see in the caller why it's convenient to have a single signature, and it's a private method, so not a big deal. Just seems messy. http://gerrit.cloudera.org:8080/#/c/20131/37/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20131/37/tests/custom_cluster/test_events_custom_configs.py@1512 PS37, Line 1512: client.set_configuration({"sync_hms_events_wait_time_s": 60}) Does this wait for 60 seconds? Or it ends early because event polling is disabled? Why use such a large wait time and timeout? -- To view, visit http://gerrit.cloudera.org:8080/20131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36ac941bb2c2217b09fcfa2eb567b011b38efa2a Gerrit-Change-Number: 20131 Gerrit-PatchSet: 37 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 18 Feb 2025 22:35:09 +0000 Gerrit-HasComments: Yes
