Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22362 )
Change subject: IMPALA-13682: Implement missing capabilities in ImpylaHS2Client ...................................................................... Patch Set 12: (15 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@188 PS12, Line 188: h flake8: U100 Unused argument 'handle' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@188 PS12, Line 188: f flake8: U100 Unused argument 'fetch_profile_after_close' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@199 PS12, Line 199: o flake8: U100 Unused argument 'operation_handle' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@269 PS12, Line 269: s flake8: U100 Unused argument 'sql_stmt' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@269 PS12, Line 269: o flake8: U100 Unused argument 'operation_handle' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@269 PS12, Line 269: m flake8: U100 Unused argument 'max_rows' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@269 PS12, Line 269: d flake8: U100 Unused argument 'discard_results' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@278 PS12, Line 278: o flake8: U100 Unused argument 'operation_handle' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@279 PS12, Line 279: p flake8: U100 Unused argument 'profile_format' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@343 PS12, Line 343: o flake8: U100 Unused argument 'operation_handle' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@343 PS12, Line 343: t flake8: U100 Unused argument 'timeout_s' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@350 PS12, Line 350: o flake8: U100 Unused argument 'operation_handle' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_connection.py@830 PS12, Line 830: s flake8: U100 Unused argument 'sql_stmt' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_test_suite.py@347 PS12, Line 347: t flake8: U100 Unused argument 'test_method' http://gerrit.cloudera.org:8080/#/c/22362/12/tests/common/impala_test_suite.py@351 PS12, Line 351: t flake8: U100 Unused argument 'test_method' -- To view, visit http://gerrit.cloudera.org:8080/22362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ac07732424c16338e060c9392100b54337f11b8 Gerrit-Change-Number: 22362 Gerrit-PatchSet: 12 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 13 Feb 2025 16:01:55 +0000 Gerrit-HasComments: Yes
