Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 31: (3 comments) http://gerrit.cloudera.org:8080/#/c/21803/29//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21803/29//COMMIT_MSG@25 PS29, Line 25: CancelledException is implemented as a RuntimeException for the moment : because exception propagation requires a lot of updates; this is similar : to LocalCatalogException, and both should be cleaned up. > Implementing proper exception propagation in catalogd is the bulk of new wo Ack. Let me have another look tomorrow. http://gerrit.cloudera.org:8080/#/c/21803/29/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/21803/29/common/thrift/CatalogService.thrift@596 PS29, Line 596: : // Common header included in all CatalogService requests. : 6: optional TCatalogServiceRequestHeader header > Yes, it's because header is usually the second field. This was also done in Ack http://gerrit.cloudera.org:8080/#/c/21803/29/common/thrift/CatalogService.thrift@780 PS29, Line 780: 2: required Types.TUniqueId query_id > I suppose it could be. In this case we're acting directly on this field, so I think it is worth to change to TCatalogServiceRequestHeader For example, this field may be matter if KILL QUERY issued by other user. // The effective user who submitted this request. When kerberos is enabled, this // contains the fully qualified user principal. 1: optional string requesting_user -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 31 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 12 Feb 2025 23:50:11 +0000 Gerrit-HasComments: Yes
