Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22049 )
Change subject: WIP IMPALA-10319: Support arbitrary encodings on Text/Sequence files ...................................................................... Patch Set 9: (17 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py File tests/query_test/test_charcodec.py: http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@23 PS9, Line 23: from tests.common.test_result_verifier import verify_query_result_is_equal flake8: F401 'tests.common.test_result_verifier.verify_query_result_is_equal' imported but unused http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@44 PS9, Line 44: u flake8: F821 undefined name 'unichr' http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@45 PS9, Line 45: u flake8: F821 undefined name 'unichr' http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@46 PS9, Line 46: u flake8: F821 undefined name 'unichr' http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@48 PS9, Line 48: u flake8: F821 undefined name 'unichr' http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@49 PS9, Line 49: u flake8: F821 undefined name 'unichr' http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@59 PS9, Line 59: class TestCharCodecGen(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@135 PS9, Line 135: v flake8: U100 Unused argument 'vector' http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@147 PS9, Line 147: v flake8: U100 Unused argument 'vector' http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@174 PS9, Line 174: v flake8: U100 Unused argument 'vector' http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@203 PS9, Line 203: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@203 PS9, Line 203: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@225 PS9, Line 225: v flake8: U100 Unused argument 'vector' http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@233 PS9, Line 233: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@289 PS9, Line 289: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@289 PS9, Line 289: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22049/9/tests/query_test/test_charcodec.py@291 PS9, Line 291: v flake8: U100 Unused argument 'vector' -- To view, visit http://gerrit.cloudera.org:8080/22049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I787cd01caa52a19d6645519a6cedabe0a5253a65 Gerrit-Change-Number: 22049 Gerrit-PatchSet: 9 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 11 Feb 2025 21:48:09 +0000 Gerrit-HasComments: Yes
