Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22460 )
Change subject: IMPALA-13741: Ignore flake8 W504 during precommit quick checks ...................................................................... Patch Set 2: Code-Review-1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22460/2/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22460/2/bin/jenkins/critique-gerrit-review.py@55 PS2, Line 55: FLAKE8_IGNORE_W504 = "--ignore=W504" > Why this is not set in https://github.com/apache/impala/blob/master/setup.c I forgot we have prior art stating we should slowly migrate to the new rule. Let's stick with that direction. -- To view, visit http://gerrit.cloudera.org:8080/22460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id118c4a92dcce1b7a315f85c2bcc9afdd5b6b886 Gerrit-Change-Number: 22460 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2025 17:35:37 +0000 Gerrit-HasComments: Yes
