Steve Carlin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22405 )
Change subject: IMPALA-13576: Fix filter placement in the plan and related changes. ...................................................................... IMPALA-13576: Fix filter placement in the plan and related changes. This patch combines the following changes: - Filter above a Sort RelNode is now supported (IMPALA-13576) - A new rule is added to remove empty sort keys, as in the example SELECT '1' FROM alltypestiny ORDER BY 1 This also required bumping up the Calcite version to 1.37. (IMPALA-13578) - A parser fix to allow LIMIT clause in a subquery (IMPALA-13579) - Added optimization to push Filter past the Project RelNode (IMPALA-13577) This optimization needs to be added before "CoerceNodes" so that the filter does not get passed through a generated Project RelNode created for handling conversion of Calcite literal types to Impala literal types (see ImpalaProjectRel.isCoercedProjectForValues() method for details on that). Change-Id: Id075d8516f1fcff4e6402c2ab4b4992a174c8151 Reviewed-on: http://gerrit.cloudera.org:8080/22405 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Aman Sinha <[email protected]> --- M java/calcite-planner/pom.xml M java/calcite-planner/src/main/codegen/templates/Parser.jj M java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaSortRel.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java 5 files changed, 16 insertions(+), 12 deletions(-) Approvals: Impala Public Jenkins: Verified Aman Sinha: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id075d8516f1fcff4e6402c2ab4b4992a174c8151 Gerrit-Change-Number: 22405 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]>
