Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22453 )
Change subject: IMPALA-13736: Fix Use-After-Free in ExecutorGroup.RemoveExecutor ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22453/2/be/src/scheduling/executor-group.cc File be/src/scheduling/executor-group.cc: http://gerrit.cloudera.org:8080/#/c/22453/2/be/src/scheduling/executor-group.cc@155 PS2, Line 155: const std::string be_hostname = be_desc.address().hostname(); Please include a comment here about why we're making copies, so it doesn't get "cleaned up" later. -- To view, visit http://gerrit.cloudera.org:8080/22453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If14a3c89ee631ebb05efc9a47745f7e63ab98690 Gerrit-Change-Number: 22453 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 05 Feb 2025 19:38:01 +0000 Gerrit-HasComments: Yes
