Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/22412 )
Change subject: IMPALA-13571: Calcite Planner: Fix join parsing errors. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22412/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java: http://gerrit.cloudera.org:8080/#/c/22412/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@105 PS4, Line 105: tableVisitor.checkForComplexTable(stmtTableCache_, errorTables, queryCtx); > Gonna reply to both comments here. Ok, let's remove this errorLoader instantiation here since it is not being used. The other instantiation in the checkForComplexTable() can remain. -- To view, visit http://gerrit.cloudera.org:8080/22412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd0f68441c84b090ed2cb45de96ccee1054deef5 Gerrit-Change-Number: 22412 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 05 Feb 2025 01:20:13 +0000 Gerrit-HasComments: Yes
