Sai Hemanth Gantasala has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22197 )

Change subject: IMPALA-13599: Reduce the number of interactions with 
alter_partition() HMS API
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22197/4/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/22197/4/tests/custom_cluster/test_events_custom_configs.py@1483
PS4, Line 1483:     log_regex = r"HMS alterPartitions done on {}/{} partitions 
of table {}" \
              :         .format(3, 3, test_tbl)
> I don't indent to implement it in this patch, but it would be nice to have
Ack. I created https://issues.apache.org/jira/browse/IMPALA-13733 to track this.


http://gerrit.cloudera.org:8080/#/c/22197/4/tests/custom_cluster/test_events_custom_configs.py@1487
PS4, Line 1487: p>=0
> I learned something today, I didn't know that we can use predicates beside
:)



--
To view, visit http://gerrit.cloudera.org:8080/22197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f2f1d9637e8be9c931da0415a17dd0839637e4c
Gerrit-Change-Number: 22197
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Tue, 04 Feb 2025 22:14:57 +0000
Gerrit-HasComments: Yes

Reply via email to