Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22441 )
Change subject: Refactor: Move FileDescriptor, FileBlock and BlockReplica ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Thanks, Gabor! http://gerrit.cloudera.org:8080/#/c/22441/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22441/4//COMMIT_MSG@7 PS4, Line 7: FileDescriptor > Would it make sense to call these "HdfsFileDescriptor" etc.? Or are they al FileDescriptor is commonly used by both HDFS and Iceberg files. It covers the functionality for HDFS files entirely. IUC Iceberg extends it with additional metadata to store Iceberg specific info. I don't think we should rename it, because that would imply a reliance on HDFS for Iceberg, which is exactly what we want to get rid of. FileDescriptor is a perfect name for the class IMO. http://gerrit.cloudera.org:8080/#/c/22441/4/fe/src/main/java/org/apache/impala/catalog/BlockReplica.java File fe/src/main/java/org/apache/impala/catalog/BlockReplica.java: http://gerrit.cloudera.org:8080/#/c/22441/4/fe/src/main/java/org/apache/impala/catalog/BlockReplica.java@25 PS4, Line 25: nit: the -- To view, visit http://gerrit.cloudera.org:8080/22441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2eb713619d4d231cec65a58255c3ced7b12d1880 Gerrit-Change-Number: 22441 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Tue, 04 Feb 2025 14:29:55 +0000 Gerrit-HasComments: Yes
