Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22422 )
Change subject: IMPALA-13703: Cancel running queries before shutdown deadline ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/22422/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22422/6//COMMIT_MSG@9 PS6, Line 9: Impala Impala daemon http://gerrit.cloudera.org:8080/#/c/22422/6//COMMIT_MSG@15 PS6, Line 15: Impala Impala daemon http://gerrit.cloudera.org:8080/#/c/22422/6//COMMIT_MSG@20 PS6, Line 20: Otherwise, : it continues to shutdown once the deadline is reached, leaving : any still running queries. Maybe rephrase: Otherwise, it shuts down once the deadline is reached, with queries still running. http://gerrit.cloudera.org:8080/#/c/22422/6/be/src/runtime/query-exec-mgr.cc File be/src/runtime/query-exec-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22422/6/be/src/runtime/query-exec-mgr.cc@261 PS6, Line 261: vector<QueryCancellationTask> to_cancel We could pass this vector by reference to CollectQueriesToCancel and avoid copy. Similar comment for other callers. -- To view, visit http://gerrit.cloudera.org:8080/22422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cac2e100d329644e21fdceb0b23901b08079130 Gerrit-Change-Number: 22422 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 04 Feb 2025 00:50:25 +0000 Gerrit-HasComments: Yes
