Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22404 )
Change subject: IMPALA-13694: Add ImpalaTestSuite.__reset_impala_clients method ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22404/3/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22404/3/tests/common/impala_connection.py@75 PS3, Line 75: if ',' in val: Should we check if 'val' is already quoted? http://gerrit.cloudera.org:8080/#/c/22404/3/tests/common/impala_connection.py@239 PS3, Line 239: self.__collect_default_options() This is not thread-safe. Do we know if some parallel e2e tests share the client? http://gerrit.cloudera.org:8080/#/c/22404/3/tests/query_test/test_exprs.py File tests/query_test/test_exprs.py: http://gerrit.cloudera.org:8080/#/c/22404/3/tests/query_test/test_exprs.py@313 PS3, Line 313: client = self.create_impala_client_from_vector(vector) Should we close this? -- To view, visit http://gerrit.cloudera.org:8080/22404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb47fec9f384cb58b19fdbd10ff7aa0850ad6277 Gerrit-Change-Number: 22404 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2025 14:00:46 +0000 Gerrit-HasComments: Yes
