Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22095 )
Change subject: IMPALA-13521: Calcite planner: Handle function problem with char params ...................................................................... Patch Set 3: Code-Review+1 (1 comment) This makes sense to me http://gerrit.cloudera.org:8080/#/c/22095/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java: http://gerrit.cloudera.org:8080/#/c/22095/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java@141 PS3, Line 141: cdoesn't Nit: "doesn't" -- To view, visit http://gerrit.cloudera.org:8080/22095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc07c6cacb81d02ba0659f2f3d8ececcc63f715e Gerrit-Change-Number: 22095 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 29 Jan 2025 19:19:44 +0000 Gerrit-HasComments: Yes
