Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22388 )

Change subject: IMPALA-13691: Partition values from HMS events don't need URL 
decoding
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22388/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

http://gerrit.cloudera.org:8080/#/c/22388/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2695
PS1, Line 2695: ().split("=");
> Maybe the name could indicate the difference from  getTypeCompatiblePartVal
Good point. The paramater is Path. So I renamed this to getPartValueFromPath.



--
To view, visit http://gerrit.cloudera.org:8080/22388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ba7fbbed47d39b02fa0b1b86d27dcda5468e344
Gerrit-Change-Number: 22388
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 26 Jan 2025 00:20:31 +0000
Gerrit-HasComments: Yes

Reply via email to