Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22103 )
Change subject: IMPALA-13520: Support in clause coercing ...................................................................... Patch Set 3: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22103/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/CombineValueNodesRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/CombineValueNodesRule.java: http://gerrit.cloudera.org:8080/#/c/22103/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/CombineValueNodesRule.java@60 PS3, Line 60: ImmutableList.Builder<ImmutableList<RexLiteral>> rowBuilder = new ImmutableList.Builder(); line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I310d3d8deb489e097dd58ef8f8bc63aefe118051 Gerrit-Change-Number: 22103 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 16:38:40 +0000 Gerrit-HasComments: Yes
