Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22130 )
Change subject: IMPALA-13565: Add general AI platform support to ai_generate_text ...................................................................... Patch Set 9: (2 comments) Thanks Gokul for the review. http://gerrit.cloudera.org:8080/#/c/22130/8/be/src/exprs/ai-functions.h File be/src/exprs/ai-functions.h: http://gerrit.cloudera.org:8080/#/c/22130/8/be/src/exprs/ai-functions.h@65 PS8, Line 65: // Default of api standard is OPEN_AI > typo: "standard" Done http://gerrit.cloudera.org:8080/#/c/22130/8/be/src/exprs/ai-functions.inline.h File be/src/exprs/ai-functions.inline.h: http://gerrit.cloudera.org:8080/#/c/22130/8/be/src/exprs/ai-functions.inline.h@100 PS8, Line 100: // If options is NULL or empty, return with defaults. > Typo: Extra space Done -- To view, visit http://gerrit.cloudera.org:8080/22130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ea2e1946089f262dda7ace73d5f7e37a5c98b14 Gerrit-Change-Number: 22130 Gerrit-PatchSet: 9 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward (801) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2025 22:49:16 +0000 Gerrit-HasComments: Yes
