Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22039 )
Change subject: IMPALA-13324: Enable statement rewrite for merge queries for IcebergMergeImpl ...................................................................... Patch Set 6: Code-Review+2 (2 comments) LGTM! http://gerrit.cloudera.org:8080/#/c/22039/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test: http://gerrit.cloudera.org:8080/#/c/22039/6/testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-partition.test@304 PS6, Line 304: a nit: no need for 'a' http://gerrit.cloudera.org:8080/#/c/22039/6/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test File testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test: http://gerrit.cloudera.org:8080/#/c/22039/6/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking.test@715 PS6, Line 715: source.id small suggestion: it would be easier to understand the RESULTS section if it was 'source.id + 100' -- To view, visit http://gerrit.cloudera.org:8080/22039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26e5661274aade3f74a386802c0ed20e5cb068b5 Gerrit-Change-Number: 22039 Gerrit-PatchSet: 6 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 13 Jan 2025 14:17:29 +0000 Gerrit-HasComments: Yes
