Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/22329 )
Change subject: IMPALA-12494: Clamp MEM_LIMIT_EXECUTORS and MEM_LIMIT_COORDINATORS ...................................................................... Patch Set 2: (5 comments) I read through quickly, I have only nits http://gerrit.cloudera.org:8080/#/c/22329/2/be/src/scheduling/admission-controller-test.cc File be/src/scheduling/admission-controller-test.cc: http://gerrit.cloudera.org:8080/#/c/22329/2/be/src/scheduling/admission-controller-test.cc@1337 PS2, Line 1337: config_d.min_query_mem_limit_coordinators = 600L * MEGABYTE; Nit: MAYBE the test is more readable if we used a raw number like 629145600 as then I can see it is the same as the value in the error message. http://gerrit.cloudera.org:8080/#/c/22329/2/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/22329/2/common/thrift/metrics.json@253 PS2, Line 253: option Nit: "options" http://gerrit.cloudera.org:8080/#/c/22329/2/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22329/2/tests/custom_cluster/test_admission_controller.py@787 PS2, Line 787: is Nit: "are", also micro-nit, capitalize sentence and end with period. http://gerrit.cloudera.org:8080/#/c/22329/2/tests/custom_cluster/test_admission_controller.py@799 PS2, Line 799: is Nit: "are", also micro-nit, capitalize sentence and end with period. http://gerrit.cloudera.org:8080/#/c/22329/2/tests/custom_cluster/test_admission_controller.py@811 PS2, Line 811: is Nit: "are", also micro-nit, capitalize sentence and end with period. -- To view, visit http://gerrit.cloudera.org:8080/22329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I262910284cbf84b8ba7e0c949bbf053dbfe44a0d Gerrit-Change-Number: 22329 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 11 Jan 2025 01:45:19 +0000 Gerrit-HasComments: Yes
