Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22319 )
Change subject: WIP: do not review, Calcite part ...................................................................... Patch Set 3: (12 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java: http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@72 PS3, Line 72: public class CalciteAnalysisDriver implements AnalysisDriver { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@73 PS3, Line 73: protected static final Logger LOG = LoggerFactory.getLogger(CalciteAnalysisDriver.class.getName()); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@105 PS3, Line 105: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@113 PS3, Line 113: CalciteMetadataHandler.populateCalciteSchema(reader_, ctx_.getCatalog(), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@115 PS3, Line 115: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteAnalysisDriver.java@148 PS3, Line 148: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java: http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java@45 PS3, Line 45: protected static final Logger LOG = LoggerFactory.getLogger(CalciteParsedStatement.class.getName()); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java@100 PS3, Line 100: @Override line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatementCreator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatementCreator.java: http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatementCreator.java@49 PS3, Line 49: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalcitePhysPlanCreator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalcitePhysPlanCreator.java: http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalcitePhysPlanCreator.java@60 PS3, Line 60: this.plannerContext_ = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@120 PS3, Line 120: protected static final Logger LOG = LoggerFactory.getLogger(CalciteSingleNodePlanner.class.getName()); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/22319/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@125 PS3, Line 125: public CalciteSingleNodePlanner(PlannerContext ctx, CalciteAnalysisDriver analysisDriver) { line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b30571beb797ede827ef4d794b8daefb130ccb1 Gerrit-Change-Number: 22319 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2025 00:57:37 +0000 Gerrit-HasComments: Yes
