Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 30: (3 comments) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/21930/20/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21930/20/be/src/service/client-request-state.cc@2494 PS20, Line 2494: if (!get_proxy_status.ok()) { : rpc_errors.emplace_back(Substitute( : "KillQuery: Could not get Proxy to ControlSer > If KILL query is not implemented like regular query, then it might not subj I tried with some debug actions. I think currently user cannot interrupt it and will have to wait. I think the RPC timeout here could help in this case to avoid waiting indefinitely. http://gerrit.cloudera.org:8080/#/c/21930/20/be/src/service/client-request-state.cc@2500 PS20, Line 2500: } > Actually, never mind about reporting progress. Lets consider that for later Thanks! Changed and added a new test case. http://gerrit.cloudera.org:8080/#/c/21930/24/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21930/24/be/src/service/impala-server.cc@1795 PS24, Line 1795: RETURN_IF_ERROR(GetActiveQueryHandle(query_id, &query_handle)); > Agree with Michael. ImpalaServer::CancelInternal() can remain unchanged. Thanks! Changed. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 30 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2025 10:37:19 +0000 Gerrit-HasComments: Yes
