Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 )
Change subject: IMPALA-12709: Add support for hierarchical metastore event processing ...................................................................... Patch Set 33: (1 comment) http://gerrit.cloudera.org:8080/#/c/21031/33/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/21031/33/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@661 PS33, Line 661: // List of DB event executors : private List<DBEventExecutor> dbEventExecutors_ = Collections.emptyList(); I think you should wrap this list of dbEventExecutors_ and its associated methods into a dedicated class. Lets call it EventExecutorService with constructor like: EventExecutorService(int numDbEventExecutor, int numTableEventExecutor); Later on, you can stress test this EventExecutorService in its own FE test or benchmark program, outside CatalogD. You can craft test-only DB/Table event that does nothing (no-op), and create random sequence of those test-only events to test how this EventExecutorService scale, whether if events dispatched correctly, etc. -- To view, visit http://gerrit.cloudera.org:8080/21031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6 Gerrit-Change-Number: 21031 Gerrit-PatchSet: 33 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2025 04:46:53 +0000 Gerrit-HasComments: Yes
