Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22306 )
Change subject: WIP: do not review ...................................................................... Patch Set 1: (17 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@590 PS1, Line 590: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@616 PS1, Line 616: // accurate count of the total number of expressions. The first analyze() call is not line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@617 PS1, Line 617: // very expensive (~seconds) even for large statements. The limit on the total length line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@620 PS1, Line 620: // expensive with large expression trees. For example, a SQL that takes a few seconds line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@623 PS1, Line 623: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@635 PS1, Line 635: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@639 PS1, Line 639: shouldReAnalyze = analysisResult_.stmt_.resolveTableMask(analysisResult_.analyzer_); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@644 PS1, Line 644: // To be consistent with Hive, privilege requests introduced by the masking views line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@674 PS1, Line 674: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@675 PS1, Line 675: // For SetOperationStmt we must replace the query statement with the rewritten version line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@688 PS1, Line 688: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@693 PS1, Line 693: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@704 PS1, Line 704: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@745 PS1, Line 745: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/service/Frontend.java@472 PS1, Line 472: "org.apache.impala.calcite.service.CalciteParsedStatementCreator").newInstance(); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/main/java/org/apache/impala/service/Frontend.java@481 PS1, Line 481: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/22306/1/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@284 PS1, Line 284: AnalysisDriverImpl analysisDriver = (AnalysisDriverImpl) stmt.getAnalysisDriver(ctx); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I978aa48b160984ee5d36244cd915940f838d141d Gerrit-Change-Number: 22306 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 06 Jan 2025 19:32:29 +0000 Gerrit-HasComments: Yes
