Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22264 )
Change subject: IMPALA-13305: Better thrift compatibility checks based on pyparsing ...................................................................... Patch Set 10: (1 comment) Fixed an issue that complex field types like "list<string>" are just shown as first level types like "list". Updated the test for that. http://gerrit.cloudera.org:8080/#/c/22264/9/bin/jenkins/thrift_parser.py File bin/jenkins/thrift_parser.py: http://gerrit.cloudera.org:8080/#/c/22264/9/bin/jenkins/thrift_parser.py@122 PS9, Line 122: turn str(toks) > Just a thought, can you make this script report if there is a new field or I think it won't be hard. Now 'optionalCommaOrSemi' uses 'SEMI' which is Suppress(';'). So the semicolon is ignored in the result tokens. We can simply use optionalCommaOrSemi = Optional("," | ";") Then check whether the last token is the comma or semicolon in create_thrift_field(). However, currently we just check thrift files related to catalogd RPCs. We'd better add a new method in critique-gerrit-review.py to check all thrift files about this. Might be more clean to do in a separate patch. -- To view, visit http://gerrit.cloudera.org:8080/22264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1dc4112404d0e7c5df94ee9f59a4fe2084b360d Gerrit-Change-Number: 22264 Gerrit-PatchSet: 10 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 06 Jan 2025 14:43:37 +0000 Gerrit-HasComments: Yes
