Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22295 )
Change subject: IMPALA-13638: Translate apostrophe to underscore in Prometheus metric names. ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/22295/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22295/1//COMMIT_MSG@17 PS1, Line 17: https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels > I don't know! I'm inclined to keep the fix focused on what was broken. Hope Yes, the python test makes new errors noisy, in this case, I think, it's enough. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/22295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I557b123c075dff0b14ac527de08bc6177bd2a3f6 Gerrit-Change-Number: 22295 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 06 Jan 2025 07:33:11 +0000 Gerrit-HasComments: Yes
