Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22294 )
Change subject: IMPALA-13637: Add flag skip_tuple_analysis_in_aggregate ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22294/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22294/1//COMMIT_MSG@7 PS1, Line 7: flag > For this case, I prefer flag because I consider this as a must have feature I have the same question as Csaba. I lean towards using a query option because it provides more flexibility.If my understanding is right, a global default query option can function similarly to a flag and also requires a restart, just like a flag. But individual queries can override the query option without restarting the cluster (especially useful for a big cluster), it seems lighter and more practical for testing bad cases http://gerrit.cloudera.org:8080/#/c/22294/1//COMMIT_MSG@11 PS1, Line 11: add nit. adds http://gerrit.cloudera.org:8080/#/c/22294/1/testdata/workloads/functional-planner/queries/PlannerTest/aggregation-no-tuple-analysis.test File testdata/workloads/functional-planner/queries/PlannerTest/aggregation-no-tuple-analysis.test: http://gerrit.cloudera.org:8080/#/c/22294/1/testdata/workloads/functional-planner/queries/PlannerTest/aggregation-no-tuple-analysis.test@1 PS1, Line 1: # TPCDS-Q19 Could we add a comment here to clarify that this test case is valid only when flag skip_tuple_analysis_in_aggregate is set to true? -- To view, visit http://gerrit.cloudera.org:8080/22294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabd8daa3d9414fc33d232643014042dc20530514 Gerrit-Change-Number: 22294 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 04 Jan 2025 01:42:52 +0000 Gerrit-HasComments: Yes
