Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 24: (3 comments) http://gerrit.cloudera.org:8080/#/c/21930/17/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21930/17/be/src/service/client-request-state.cc@2524 PS17, Line 2524: > Thanks! Changed. Done http://gerrit.cloudera.org:8080/#/c/21930/24/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/21930/24/be/src/service/impala-server.h@858 PS24, Line 858: Status CancelInternal(const TUniqueId& query_id, bool from_kill_query_statement); I'd lean towards defaulting from_kill_query_statement=false, since it's an exceptional case. It'd be nice if the function comment described how CancelInternal's behavior changes when this argument is specified. http://gerrit.cloudera.org:8080/#/c/21930/24/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21930/24/be/src/service/impala-server.cc@1795 PS24, Line 1795: << ", from_kill_query_statement=" << from_kill_query_statement; This seems a little weird, but I agree it's useful to differentiate. I'd also be happy with having KillQuery log a message about the requesting user to provide the same benefit and a bit more detail. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 24 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 03 Jan 2025 17:53:01 +0000 Gerrit-HasComments: Yes
