Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 )
Change subject: IMPALA-12709: Add support for hierarchical metastore event processing ...................................................................... Patch Set 28: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21031/28/fe/src/main/java/org/apache/impala/catalog/events/RenameTableBarrierEvent.java File fe/src/main/java/org/apache/impala/catalog/events/RenameTableBarrierEvent.java: http://gerrit.cloudera.org:8080/#/c/21031/28/fe/src/main/java/org/apache/impala/catalog/events/RenameTableBarrierEvent.java@130 PS28, Line 130: if (catalogOpExecutor_.addTableIfNotRemovedLater(getEventId(), pseudoEvent_.getTable())) { line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21031/28/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21031/28/tests/custom_cluster/test_events_custom_configs.py@1369 PS28, Line 1369: flake8: E222 multiple spaces after operator http://gerrit.cloudera.org:8080/#/c/21031/28/tests/custom_cluster/test_events_custom_configs.py@1377 PS28, Line 1377: flake8: E222 multiple spaces after operator http://gerrit.cloudera.org:8080/#/c/21031/28/tests/custom_cluster/test_events_custom_configs.py@1388 PS28, Line 1388: flake8: E222 multiple spaces after operator http://gerrit.cloudera.org:8080/#/c/21031/28/tests/custom_cluster/test_events_custom_configs.py@1392 PS28, Line 1392: flake8: E222 multiple spaces after operator http://gerrit.cloudera.org:8080/#/c/21031/28/tests/util/event_processor_utils.py File tests/util/event_processor_utils.py: http://gerrit.cloudera.org:8080/#/c/21031/28/tests/util/event_processor_utils.py@80 PS28, Line 80: + flake8: W504 line break after binary operator -- To view, visit http://gerrit.cloudera.org:8080/21031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6 Gerrit-Change-Number: 21031 Gerrit-PatchSet: 28 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 02 Jan 2025 06:46:34 +0000 Gerrit-HasComments: Yes
