Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22264 )
Change subject: IMPALA-13305: Better thrift compatibility checks based on pyparsing ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/22264/3/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22264/3/bin/jenkins/critique-gerrit-review.py@53 PS3, Line 53: > Oh, I just realize we already use pyparsing in other place! I think it's ok Changed to 3.1.4 since somehow the env in Jenkins can't install this version.: + /var/lib/jenkins/workspace/gerrit-auto-critic-test/Impala/bin/jenkins/critique-gerrit-review.py --dryrun Requirement already satisfied: wheel in /usr/lib/python3/dist-packages (0.34.2) Collecting flake8==7.1.1 Using cached flake8-7.1.1-py2.py3-none-any.whl (57 kB) Processing /var/lib/jenkins/.cache/pip/wheels/d1/a9/a9/cc03c41c768c6e2f7b2a995d6814c49880b8aacafb70a53d7c/flake8_diff-0.2.2-py3-none-any.whl ERROR: Could not find a version that satisfies the requirement pyparsing==3.2.0 (from versions: 1.4.6, 1.4.7, 1.4.8, 1.4.11, 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.5.5, 1.5.6, 1.5.7, 2.0.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4, 2.0.5, 2.0.6, 2.0.7, 2.1.0, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.1.5, 2.1.6, 2.1.7, 2.1.8, 2.1.9, 2.1.10, 2.2.0, 2.2.1, 2.2.2, 2.3.0, 2.3.1, 2.4.0, 2.4.1.1, 2.4.2a1, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 3.0.0a1, 3.0.0a2, 3.0.0b1, 3.0.0b2, 3.0.0b3, 3.0.0rc1, 3.0.0rc2, 3.0.0, 3.0.1, 3.0.2, 3.0.3, 3.0.4, 3.0.5, 3.0.6, 3.0.7, 3.0.8, 3.0.9, 3.1.0a1, 3.1.0b1, 3.1.0b2, 3.1.0, 3.1.1, 3.1.2, 3.1.3, 3.1.4) ERROR: No matching distribution found for pyparsing==3.2.0 Traceback (most recent call last): File "/var/lib/jenkins/workspace/gerrit-auto-critic-test/Impala/bin/jenkins/critique-gerrit-review.py", line 432, in <module> setup_virtualenv() File "/var/lib/jenkins/workspace/gerrit-auto-critic-test/Impala/bin/jenkins/critique-gerrit-review.py", line 129, in setup_virtualenv check_call([PIP_PATH, "install", File "/usr/lib/python3.8/subprocess.py", line 364, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['gerrit_critic_venv/bin/pip3', 'install', 'wheel', 'flake8==7.1.1', 'flake8-diff==0.2.2', 'pyparsing==3.2.0']' returned non-zero exit status 1. https://jenkins.impala.io/job/gerrit-auto-critic-test/2/console http://gerrit.cloudera.org:8080/#/c/22264/6/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22264/6/bin/jenkins/critique-gerrit-review.py@334 PS6, Line 334: # Importing thrift_parser depends on pyparsing being installed in setup_virtualenv(). : from thrift_parser import extract_thrift_defs This still failed by "ModuleNotFoundError: No module named 'pyparsing'" https://jenkins.impala.io/job/gerrit-auto-critic-test/3/console -- To view, visit http://gerrit.cloudera.org:8080/22264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1dc4112404d0e7c5df94ee9f59a4fe2084b360d Gerrit-Change-Number: 22264 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 31 Dec 2024 04:50:14 +0000 Gerrit-HasComments: Yes
