Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 18: (3 comments) > Patch Set 17: > > (7 comments) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/21930/17/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21930/17/be/src/service/client-request-state.cc@2524 PS17, Line 2524: return status; > I think the idea was that the KillQuery API would also have an is_admin par Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/21930/17/be/src/service/client-request-state.cc@2538 PS17, Line 2538: } > This pattern looks weird, but I'm not very familiar with the protobuf class I think add_query_ids() is used to add a new element to the repeated field 'query_ids'. http://gerrit.cloudera.org:8080/#/c/21930/17/tests/util/cancel_util.py File tests/util/cancel_util.py: http://gerrit.cloudera.org:8080/#/c/21930/17/tests/util/cancel_util.py@23 PS17, Line 23: from tests.common.test_result_verifier import error_msg_expected > I think this utility should live in this file, and test_kill_query should i Thanks! Moved the utils to this file and removed the two __init__.py files. Added file tests/common/cluster_config.py to make common cluster configs easily reusable in custom cluster tests. Is that OK? -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 18 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 30 Dec 2024 07:37:17 +0000 Gerrit-HasComments: Yes
