Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22271 )
Change subject: refactored TCatalogOpRequest stuff ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22271/1/fe/src/main/java/org/apache/impala/analysis/DescribeDbStmt.java File fe/src/main/java/org/apache/impala/analysis/DescribeDbStmt.java: http://gerrit.cloudera.org:8080/#/c/22271/1/fe/src/main/java/org/apache/impala/analysis/DescribeDbStmt.java@112 PS1, Line 112: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22271/1/fe/src/main/java/org/apache/impala/analysis/StatementBase.java File fe/src/main/java/org/apache/impala/analysis/StatementBase.java: http://gerrit.cloudera.org:8080/#/c/22271/1/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@304 PS1, Line 304: public TCatalogOpRequest getTCatalogOpRequest(TQueryOptions queryOptions) line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22271/1/fe/src/main/java/org/apache/impala/planner/PlannerDriver.java File fe/src/main/java/org/apache/impala/planner/PlannerDriver.java: http://gerrit.cloudera.org:8080/#/c/22271/1/fe/src/main/java/org/apache/impala/planner/PlannerDriver.java@309 PS1, Line 309: StatementBase stmt = analysisResult.getStmt(); line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/22271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03568fd7784bd8af6b3a5fbe384cc092f321094a Gerrit-Change-Number: 22271 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 29 Dec 2024 15:38:10 +0000 Gerrit-HasComments: Yes
