Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22265 )
Change subject: more small fixes for parsedstatement ...................................................................... Patch Set 1: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22265/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/22265/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@785 PS1, Line 785: AnalyzesOk("alter table functional.alltypesmixedformat partition(year=2009,month=1) " + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22265/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@3517 PS1, Line 3517: + " prepare_fn='_Z19ValidateOpenPreparePN10impala_udf15FunctionContextENS0_18FunctionStateScopeE'" line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/22265/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@3518 PS1, Line 3518: + " close_fn='_Z17ValidateOpenClosePN10impala_udf15FunctionContextENS0_18FunctionStateScopeE'"); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/22265/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@4306 PS1, Line 4306: "partition(string_col = 'partition1') set location '%s/new_part_loc'", location), line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22265/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/22265/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@372 PS1, Line 372: CreateTableAsSelectStmt ctasStmt = (CreateTableAsSelectStmt) parsedStmt.getTopLevelNode(); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22265/1/fe/src/test/java/org/apache/impala/common/FrontendFixture.java File fe/src/test/java/org/apache/impala/common/FrontendFixture.java: http://gerrit.cloudera.org:8080/#/c/22265/1/fe/src/test/java/org/apache/impala/common/FrontendFixture.java@270 PS1, Line 270: QueryStmt viewStmt = (QueryStmt) parseStmt(createViewStmt.getInlineViewDef()).getTopLevelNode(); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22265/1/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java File fe/src/test/java/org/apache/impala/common/TestParsedStatement.java: http://gerrit.cloudera.org:8080/#/c/22265/1/fe/src/test/java/org/apache/impala/common/TestParsedStatement.java@77 PS1, Line 77: @Override line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/22265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If65e93cb399e8d7e0da7d2ed14f4901b19460f0d Gerrit-Change-Number: 22265 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 29 Dec 2024 15:26:23 +0000 Gerrit-HasComments: Yes
