Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21475 )
Change subject: IMPALA-13124: Migrate tests that use 'unittest' package to pytest base class ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/21475/12/tests/custom_cluster/test_redaction.py File tests/custom_cluster/test_redaction.py: http://gerrit.cloudera.org:8080/#/c/21475/12/tests/custom_cluster/test_redaction.py@86 PS12, Line 86: """--impalad_args=-audit_event_log_dir=%s : -profile_log_dir=%s : -redaction_rules_file=%s : -vmodule=%s""" > nit: Unrelated, but do you think we can remove all sleep in this test if we It looks like it is checking multiple locations (regular logs, profile logs, audit logs). -logbuflevel=-1 would help with the regular logs, but it sounds like the audit logs might be slower. -- To view, visit http://gerrit.cloudera.org:8080/21475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e854f64e424a75827929a4f6841066024390e9 Gerrit-Change-Number: 21475 Gerrit-PatchSet: 12 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 17 Dec 2024 00:30:07 +0000 Gerrit-HasComments: Yes
