Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22080 )
Change subject: IMPALA-12141: EP shouldn't fail while releasing write lock if the lock is not held previously ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22080/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22080/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5073 PS1, Line 5073: return 0; nit: I think tryWriteLock() throws InternalException when fail to acquire the write lock. Please add a comment that we don't want to throw InternalException to fail EP for test purpose. http://gerrit.cloudera.org:8080/#/c/22080/1/fe/src/main/java/org/apache/impala/util/DebugUtils.java File fe/src/main/java/org/apache/impala/util/DebugUtils.java: http://gerrit.cloudera.org:8080/#/c/22080/1/fe/src/main/java/org/apache/impala/util/DebugUtils.java@98 PS1, Line 98: public static final String MOCK_WRITE_LOCK_FAILURE = "mock_write_lock_failure"; nit: please add a comment like other fields -- To view, visit http://gerrit.cloudera.org:8080/22080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e4c965796dd515ab8549efa616f72510ca447f Gerrit-Change-Number: 22080 Gerrit-PatchSet: 1 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Sat, 14 Dec 2024 03:26:40 +0000 Gerrit-HasComments: Yes
