Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/22014 )
Change subject: IMPALA-13154: Update metrics when loading an HDFS table ...................................................................... Patch Set 20: (3 comments) > Patch Set 18: > > (1 comment) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/22014/18/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/22014/18/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@1181 PS18, Line 1181: getFileDescriptors > I just realized we decode the file descriptors everytime we invoke HdfsPart Thanks! Added a check in HdfsPartition#getFileMetadataStats(). Is that OK? http://gerrit.cloudera.org:8080/#/c/22014/18/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@1755 PS18, Line 1755: if (thriftPartition.isSetFile_desc()) { : List<FileDescriptor> fds = fdsFromThrift(thriftPartition.getFile_desc()); : setFileDescriptors(fds); : for (FileDescriptor fd: fds) { : fileMetadataStats_.add(fd); : } : } : if (thriftPartition.isSetInsert_file_desc()) { : > As set*FileDescriptors() are called here, I think we can generate FileMetad Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/22014/18/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/22014/18/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1044 PS18, Line 1044: } > It's strange that 'numBlocks' is not updated here and even in the original I don't know why 'numBlocks' was not updated here either. -- To view, visit http://gerrit.cloudera.org:8080/22014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2eb503b0f61b1e6403058bc5dc78d721e7e940 Gerrit-Change-Number: 22014 Gerrit-PatchSet: 20 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 13 Dec 2024 08:29:00 +0000 Gerrit-HasComments: Yes
