Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22073 )
Change subject: IMPALA-13368: Fixup Redhat detection for Python >= 3.8 ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22073/5/tests/common/environ.py File tests/common/environ.py: http://gerrit.cloudera.org:8080/#/c/22073/5/tests/common/environ.py@64 PS5, Line 64: if distro.id() in ['rhel', 'rocky', 'centos', 'almalinux']: The 'distro' package seems to be supported on all versions of python 2.7 and later. Can the checks for versions 3.8 and older be removed and only the 'distro.id()' function be used? -- To view, visit http://gerrit.cloudera.org:8080/22073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dfaf798c0239f6068f29adbd2eafafdbbfd66c3 Gerrit-Change-Number: 22073 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Wed, 11 Dec 2024 22:19:08 +0000 Gerrit-HasComments: Yes
